Add missing algorithm header to jit_compiler.cpp for Linux builds #2460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes compilation error on Linux where std::find_if is used on line 121 but the <algorithm> header was not included. While this might work on some platforms due to transitive includes, it's not guaranteed by the C++ standard. Resolves issue ml-explore#2459
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #2459 by adding the missing algorithm header to mlx/backend/cpu/jit_compiler.cpp.
Problem
The file uses std::find_if on line 121 but wasn't including the algorithm header that defines it. While this might work on some platforms where algorithm is transitively included through other headers, it's not guaranteed by the C++ standard. On Linux with GCC/Clang, the transitive inclusion doesn't happen, causing build failures.
Solution
Added include algorithm to the includes section of jit_compiler.cpp to explicitly include the header that defines std::find_if.
Testing
Related Issues
Fixes #2459