Fix custom metal extension #2446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angeloskath
reviewed
Jul 30, 2025
.circleci/config.yml
Outdated
| @@ -167,6 +167,7 @@ jobs: | |||
| cd examples/extensions | |||
| uv pip install -r requirements.txt | |||
| uv run --no-project setup.py build_ext -j8 | |||
| python test.py | |||
There was a problem hiding this comment.
Probably uv run --no-project test.py
awni
force-pushed
the
fix_custom_extension
branch
2 times, most recently
from
712e9d5 to
ac7e6f3
Compare
awni
force-pushed
the
fix_custom_extension
branch
from
ac7e6f3 to
4426405
Compare
LVivona
pushed a commit
to LVivona/mlx
that referenced
this pull request
Jul 31, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously (a long time ago) we relied on some implicit behavior of keeping the library loading in a header so it would resolve the right path for the binary. Rather than rely on that which was evidently quite brittle, this makes it explicit in the extension code.
Closes #2436