Skip to content

[CUDA] Fix gemv regression #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

[CUDA] Fix gemv regression #2445

merged 1 commit into from
Jul 30, 2025

Conversation

awni
Copy link
Member

@awni awni commented Jul 30, 2025

Use unsafe load and store and check for alignment in dispatch.

@awni awni requested review from zcbenz and angeloskath July 30, 2025 20:35
angeloskath
angeloskath approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@angeloskath angeloskath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@awni awni merged commit d32519c into ml-explore:main Jul 30, 2025
7 checks passed
LVivona pushed a commit to LVivona/mlx that referenced this pull request Jul 31, 2025
@awni @LVivona
fix gemv regression (ml-explore#2445)
c3e38b4
@BrewTestBot BrewTestBot mentioned this pull request Aug 7, 2025
Merged
1 task
@awni awni deleted the fix_gemv branch August 14, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angeloskath angeloskath angeloskath approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@awni @angeloskath