Skip to content

[CUDA] Do not put kernels in annoymous namespace #2362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2025
Merged

[CUDA] Do not put kernels in annoymous namespace #2362

merged 1 commit into from
Jul 12, 2025

Conversation

zcbenz
Copy link
Collaborator

@zcbenz zcbenz commented Jul 12, 2025

In the profiler the kernels would have <unnamed>:: in their names, making them hard to read.

awni
awni approved these changes Jul 12, 2025
View reviewed changes
Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awni awni merged commit 2d3c26c into ml-explore:main Jul 12, 2025
5 checks passed
@zcbenz zcbenz deleted the kernel-annoymous-namespace branch July 13, 2025 00:48
@BrewTestBot BrewTestBot mentioned this pull request Jul 25, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awni awni awni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @awni