Skip to content

[CUDA] Set current device before cudaGraphLaunch #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025

Conversation

zcbenz
Copy link
Collaborator

@zcbenz zcbenz commented Jul 10, 2025

This makes sure the graph is launched in the correct device under a multi-device environment.

Also moves the code of Device::get_command_encoder up as it is in the middle of CommandEncoder method definitions.

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@awni
Copy link
Member

awni commented Jul 10, 2025

Test failure is unrelated.

@awni awni merged commit 8fb3e7a into ml-explore:main Jul 10, 2025
4 of 5 checks passed
@zcbenz zcbenz deleted the graph-current-device branch July 13, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants