MLX_SWITCH macros to templates #2320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all macros used to switch types or values to constexprs into templates.
The main benefit is that we will now have proper compiler errors instead of one huge line from the preprocessor macros. There is very little change to binary size. When we move to C++20 we can make the lambda get the type directly so we won't have to call
MLX_GET_TYPE
on the argument.@zcbenz let me know if you can think of a reason not to switch to this pattern instead.
The binary was previously 219MB and now 222MB which I think is worth it for the quality of life improvement.