Skip to content

Conversation

ozancaglayan
Copy link
Collaborator

No description provided.

@ozancaglayan ozancaglayan requested a review from mjpost March 3, 2021 09:45
@ozancaglayan ozancaglayan removed the request for review from mjpost March 3, 2021 09:54
Copy link
Owner

@mjpost mjpost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mjpost mjpost merged commit 5ce6b06 into master Mar 3, 2021
@ozancaglayan
Copy link
Collaborator Author

Thanks. It seemed important for a 1.5.1, but it's up to you.

@mjpost
Copy link
Owner

mjpost commented Mar 4, 2021

@ozancaglayan we should do a 1.5.1 release. Do you have time to update CHANGELOG and version and create a PR? If you and @martinpopel send me your mypy account IDs, I can add you to permissions for pushing out new versions, too.

@mjpost mjpost deleted the fix142 branch March 4, 2021 20:52
@mjpost
Copy link
Owner

mjpost commented Mar 4, 2021

We could include #136 with it as well.

@martinpopel
Copy link
Collaborator

If you and @martinpopel send me your mypy account IDs

I guess you mean PyPI, not mypy. My ID is "popel". I don't have much time for sacrebleu now, but I hope it will change soon.

@ozancaglayan
Copy link
Collaborator Author

ozancaglayan commented Mar 4, 2021 via email

@ozancaglayan
Copy link
Collaborator Author

v1.5.1 is tagged and released on github and PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants