Skip to content

Conversation

uweschmitt
Copy link

I'm using mistletoe to transform markdown to markdown and added setters to the content properties of block token classes in block_tokens.py.

I did not add tests yet, since I did not find a suitable place in the existing setup.

@uweschmitt
Copy link
Author

Btw: I realized that the code is not black conformant, although https://github.com/miyuchina/mistletoe/blob/master/CONTRIBUTING.md#style-guide recommends black.

@pbodnar
Copy link
Collaborator

pbodnar commented Oct 13, 2024

@uweschmitt, thanks for the PR.

I did not add tests yet, since I did not find a suitable place in the existing setup.

What about extending the TestLeafBlockTokenContentProperty tests? A little bit of contemplation on how to (re)structure the tests will be probably needed...

@pbodnar pbodnar added this to the 1.5.0 milestone Oct 13, 2024
@pbodnar
Copy link
Collaborator

pbodnar commented Oct 13, 2024

Btw: I realized that the code is not black conformant, although https://github.com/miyuchina/mistletoe/blob/master/CONTRIBUTING.md#style-guide recommends black.

Yeah, the decision to use the black formatter came relatively recently. And I'm still not sure whether we want to re-format the whole code base by applying it globally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants