Skip to content

Conversation

@Swiftb0y
Copy link
Member

@Swiftb0y Swiftb0y commented Aug 2, 2022

@ywwg requested we include the source for the import tool in our source tree.

@daschuer
Copy link
Member

daschuer commented Aug 3, 2022

The pre-commit issue is s false positive.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.
@ywwg

Do you want to have a look before merge? Do we want to merge the final version after it has been used or track changes this way?

"johan-lasperas": "johanLsp",
"josepma": "JosepMaJAZ",
"juha-pitkanen": "JuhaPit",
"jus": "esbrandt", # codespell:ignore jus
Copy link
Member

@Holzhaus Holzhaus Aug 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I line comments don't work, you need to add jus to the .codespellignore file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm aware. There is a PR that introduces inline ignores. I didn't want to add "jus" to the global .codespellignore because it could be a likely typo. I'd just wait for codespell-project/codespell#2400 before merging. 🤷

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternative to waiting is to add the entire line to a .codespellignorelines file and adding --exclude-file=.codespellignorelines to the codespell command line. Then you don't have to worry about false negatives.

@Swiftb0y
Copy link
Member Author

Swiftb0y commented Aug 3, 2022

I'd also wait with merging until we actually did the import. Its likely I'll still have to make some adjustments to the script.

@mYnDstrEAm
Copy link

Is this specific to mixxx? If not, create another separate repo for it so other Launchpad repos can find and use it too. Also see #10952

@Holzhaus
Copy link
Member

Holzhaus commented Oct 9, 2022

Is this specific to mixxx? If not, create another separate repo for it so other Launchpad repos can find and use it too. Also see #10952

It is kind of specific because it hardcodes the term "Mixxx" in various locations, maps certain Launchpad usernames to GitHub usernames, etc.

I have no intention to spend any more time on this, but the code is open source and distributed under the terms of the GPL. Feel free to modify it and put into a separate repository if you want.

@github-actions
Copy link

github-actions bot commented Jan 8, 2023

This PR is marked as stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the stale Stale issues that haven't been updated for a long time. label Jan 8, 2023
@daschuer
Copy link
Member

Do we want to merge this now?
It is for documentation purpose only, so it should be safe.

@Holzhaus
Copy link
Member

The pre-commit checks fail. If we merge this, every non-PR CI build will probably also fail.

This was due to mistakes in the calculation for the wait time
which arose because of improper handling of timezones.
Issues can be duplicates of  of issues that don't belong to the mixxx
project. Since those are obviously not imported
to github, we link to their originals
on launchpad instead of github.
Since issues get a new ID/number during bulk-transfer we need to
update our launchpad-export-json with the new numbers.
This is done via a mapping file we get from githubs bulk-transfer tools.
@Swiftb0y
Copy link
Member Author

squashed the fixup commits, rebased on latest 2.3 and fixed pre-commit

@daschuer
Copy link
Member

Thank you
@Holzhaus Can this be merged now?

@Holzhaus
Copy link
Member

Yup

@Holzhaus Holzhaus merged commit 620242d into mixxxdj:2.3 Feb 15, 2023
@Swiftb0y Swiftb0y deleted the json2github branch February 15, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale issues that haven't been updated for a long time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants