-
-
Couldn't load subscription status.
- Fork 1.5k
feat(tools): add python script used for migrating to github issues #4877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The pre-commit issue is s false positive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
@ywwg
Do you want to have a look before merge? Do we want to merge the final version after it has been used or track changes this way?
tools/json2github.py
Outdated
| "johan-lasperas": "johanLsp", | ||
| "josepma": "JosepMaJAZ", | ||
| "juha-pitkanen": "JuhaPit", | ||
| "jus": "esbrandt", # codespell:ignore jus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I line comments don't work, you need to add jus to the .codespellignore file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm aware. There is a PR that introduces inline ignores. I didn't want to add "jus" to the global .codespellignore because it could be a likely typo. I'd just wait for codespell-project/codespell#2400 before merging. 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alternative to waiting is to add the entire line to a .codespellignorelines file and adding --exclude-file=.codespellignorelines to the codespell command line. Then you don't have to worry about false negatives.
|
I'd also wait with merging until we actually did the import. Its likely I'll still have to make some adjustments to the script. |
|
Is this specific to mixxx? If not, create another separate repo for it so other Launchpad repos can find and use it too. Also see #10952 |
It is kind of specific because it hardcodes the term "Mixxx" in various locations, maps certain Launchpad usernames to GitHub usernames, etc. I have no intention to spend any more time on this, but the code is open source and distributed under the terms of the GPL. Feel free to modify it and put into a separate repository if you want. |
|
This PR is marked as stale because it has been open 90 days with no activity. |
|
Do we want to merge this now? |
|
The pre-commit checks fail. If we merge this, every non-PR CI build will probably also fail. |
This was due to mistakes in the calculation for the wait time which arose because of improper handling of timezones.
Issues can be duplicates of of issues that don't belong to the mixxx project. Since those are obviously not imported to github, we link to their originals on launchpad instead of github.
Since issues get a new ID/number during bulk-transfer we need to update our launchpad-export-json with the new numbers. This is done via a mapping file we get from githubs bulk-transfer tools.
304223e to
d113340
Compare
|
squashed the fixup commits, rebased on latest 2.3 and fixed pre-commit |
|
Thank you |
|
Yup |
@ywwg requested we include the source for the import tool in our source tree.