docs: NotificationProvider Guidelines #1907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan-Eimertenbrink
added
documentation
Jan-Eimertenbrink
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
Jan-Eimertenbrink
temporarily deployed
to
github-pages-preview-storybook
GitHub Actions
Inactive
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
Jan-Eimertenbrink
temporarily deployed
to
github-pages-preview
GitHub Actions
Inactive
Jan-Eimertenbrink
temporarily deployed
to
github-pages-preview-storybook
GitHub Actions
Inactive
kati-ux
reviewed
Aug 22, 2025
There was a problem hiding this comment.
Verbesserungen die man im Index machen sollte: "Der NotificationProvider dient zur Anzeige und Steuerung von Notifications." Provider ist maskulin und Punkt fehlt.
Da es im Overview nicht viel Text ist, kann man hier die Stil und Grammatik/Rechtschreibfehler entfernen:
- Bei Initialisierung: „…muss der als übergeordnete Component eingebunden werden.“ -> Component und "obere" liest sich komisch.
- Bei Notifications anzeigen: "Method" zu "Methode" da im späteren Text es so geschrieben wird
- Bei Manuelles schließen: "verwendetet" ist falsch -> "verwendet"
apps/docs/src/content/03-components/status/notification-provider/guidelines.mdx
Outdated
Show resolved
Hide resolved
apps/docs/src/content/03-components/status/notification-provider/guidelines.mdx
Outdated
Show resolved
Hide resolved
apps/docs/src/content/03-components/status/notification-provider/guidelines.mdx
Outdated
Show resolved
Hide resolved
apps/docs/src/content/03-components/status/notification-provider/guidelines.mdx
Outdated
Show resolved
Hide resolved
kati-ux
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.