fix(server): add shell=True to npm subprocess calls for Windows compa… #3194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tibility
fix(server): add shell=True to npm subprocess calls for Windows compatibility
Description
Description:
This pull request introduces a small but essential fix to ensure that the Caldera server can successfully invoke npm commands on Windows environments.
📌 Problem
On Windows, subprocess.Popen() or subprocess.run() calls that execute npm commands without shell=True fail with a FileNotFoundError, even when npm is available in the system's PATH. This is due to how Windows handles executable resolution without a shell context.
🔧 Changes Made
Added shell=True to all subprocess calls that include npm in server.py.
No logic or behavior change on Unix-like systems (Linux/macOS), where this argument is harmless.
✅ Tested On
✅ Windows 10/11: npm commands now execute correctly
✅ Linux (Ubuntu 22.04): no side effects observed
🛡️ Impact
This change improves cross-platform compatibility, especially for Windows users who want to contribute to or extend Caldera without having to patch the code manually.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: