Enable unsafe legacy SSL renegotiation #6281
Merged
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Doing this only when ssl_insecure is set sounds good to me! Some notes:
|
DurandA
force-pushed
the
legacy-renegotiation
branch
from
2e35adf to
fbf98ce
Compare
Contributor
Author
|
@mhils Thanks for the guidelines. Let me know if this is ok as implemented.
👍 |
mhils
added a commit
to mhils/cryptography
that referenced
this pull request
Jul 27, 2023
This is useful to expose in pyOpenSSL so that it can be referenced downstream for `Context.set_options`. (mitmproxy/mitmproxy#6281)
mhils
approved these changes
Jul 27, 2023
mhils
added a commit
to pyca/pyopenssl
that referenced
this pull request
Jul 27, 2023
Member
|
Looks great, thanks! I've filed PRs with cryptography and pyOpenSSL. :) |
alex
pushed a commit
to pyca/cryptography
that referenced
this pull request
Jul 27, 2023
This is useful to expose in pyOpenSSL so that it can be referenced downstream for `Context.set_options`. (mitmproxy/mitmproxy#6281)
alex
pushed a commit
to pyca/pyopenssl
that referenced
this pull request
Jul 29, 2023
* Expose `SSL_OP_LEGACY_SERVER_CONNECT` binding based on pyca/cryptography#9303 refs mitmproxy/mitmproxy#6281 * Update CHANGELOG.rst
lasting-yang
pushed a commit
to lasting-yang/mitmproxy
that referenced
this pull request
Aug 2, 2023
* Enable unsafe legacy renegotiation * Update CHANGELOG * Fix missing proxy_server_context argument in test * use pyopenssl's OP_LEGACY_SERVER_CONNECT --------- Co-authored-by: Maximilian Hils <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue discussed in #5422 when connecting to a server with outdated/misconfigured SSL. This is a draft PR to discuss if a full PR would be accepted. A full PR would only add the
OP_LEGACY_SERVER_CONNECTSSL context flag if thessl_insecureswitch is passed.Checklist