remove usingnamespace from main.zig #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be 100% API compatible, and I wrote a comptime test to help ensure that. Still, I suppose something could slip through. The major churn in this PR is to avoid a circular dependency when verifying that the API didn't change. We remove the dependency on main.zig from the backends, which is cleaner in general, but it makes for a big diff.
mitchellh
force-pushed
the
push-zlouoqlxtvno
branch
from
c1942dd to
393db62
Compare
Sythivo
referenced
this pull request
in Scythe-Technology/libxev
Aug 24, 2025
This should be 100% API compatible, and I wrote a comptime test to help ensure that. Still, I suppose something could slip through. The major churn in this PR is to avoid a circular dependency when verifying that the API didn't change. We remove the dependency on main.zig from the backends, which is cleaner in general, but it makes for a big diff.
jadedpasta
added a commit
to jadedpasta/libxev
that referenced
this pull request
Nov 3, 2025
It seems that mitchellh#177 had a typo that exports `stream.GenericStream` as `xev.Stream`. Export the correct item instead.
jadedpasta
added a commit
to jadedpasta/libxev
that referenced
this pull request
Nov 3, 2025
It seems that mitchellh#177 had a typo that exports `stream.GenericStream` as `xev.Stream`. Export the correct item instead. Also enhance the comptime check to ensure that the exported fields actually have the correct type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be 100% API compatible, and I wrote a comptime test to help ensure that. Still, I suppose something could slip through.
The major churn in this PR is to avoid a circular dependency when verifying that the API didn't change. We remove the dependency on main.zig from the backends, which is cleaner in general, but it makes for a big diff.