Support CommonJS and fix UMD #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/wrapper/start.frag
Outdated
I'm using this library with Browserify and found that it was unable to detect d3 correctly. This adds in the necessary `require` call to find the d3 dependency. I also changed the UMD signature to not expect that `define` and `require` are globals in the sense of the runtime, but instead are global within the encapsulating function scope (which may be the same as the runtime's). This will ensure d3.chart works as expected when bundled.
Member
|
Thanks, Tim! I want to look into an automated test for this change before it lands. That might be a little tricky, since it will involve some infrastructural work, but I don't think it will be too bad. I'll keep you posted! |
Author
|
Hope you don't mind, closing in favor of: #113 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this library with Browserify and found that it was unable to
detect d3 correctly. This adds in the necessary
requirecall to findthe d3 dependency.
I also changed the UMD signature to not expect that
defineandrequireare globals in the sense of the runtime, but instead areglobal within the encapsulating function scope (which may be the same as
the runtime's). This will ensure d3.chart works as expected when
bundled.