In before 1.0.0 is released

[rgrinberg]

Can we rename the optional argument of make:

https://github.com/avsm/ocaml-cohttp/blob/master/cohttp/cookie.ml#L37

For consistency it should expiration. Same for secure/is_secure. The label should just be the field name.

It would also make things consistent for code generators like fieldslib for getters/setters if it's decided to use them.

[avsm]

Agreed.

On 22 Nov 2013, at 18:53, Rudi Grinberg notifications@github.com wrote:

Can we rename the optional argument of make:

https://github.com/avsm/ocaml-cohttp/blob/master/cohttp/cookie.ml#L37

For consistency it should expiration. Same for secure/is_secure. The label should just be the field name.

It would also make things consistent for code generators like fieldslib for getters/setters if it's decided to use them.

—
Reply to this email directly or view it on GitHub.

[avsm]

fixed in 0.9.12