Fix assert failure and add find_opt #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the input to `from_string` is not a valid JSON array or object fixes mirage#31
avsm
added a commit
to avsm/opam-repository
that referenced
this pull request
Jul 28, 2020
CHANGES: * Add `find_opt` to provide an exception-less version of `find` (mirage/ezjsonm#39 @avsm) * Raise `Parse_error` instead of assert failure if the input to `from_string` is not a valid JSON array or object (mirage/ezjsonm#39 @avsm). * Upgrade build rules to dune 2.0 (mirage/ezjsonm#38 @avsm) * Depend on Sexplib0 instead of Sexplib since we only need the type definition. This reduces the dependency cone of Ezjsonm (and skips Base). (mirage/ezjsonm#38 @avsm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's leave the interface rev from
find->find_exnto a future major revision. This just adds afind_optin the style of the OCaml stdlib (e.g. List.assoc_opt). Also turns an assert failure into a Parse failure.