Allow running benchmarks on pull requests #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom dockerfile allows installing system dependencies like zlib, the Makefile has the "make bench" target that is run once all the dependencies are installed and the opam file allows installing necessary dependencies for the benchmarks.
|
We will also need to enable current-bench on this repo, once you take a look at this @dinosaure I can send you a request to approve running the benchmarks app. |
dinosaure
approved these changes
Feb 4, 2022
|
Thanks, it seems fine for me. I will happy to accept your request and finally see benchmarks on this project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom dockerfile allows installing system dependencies like zlib, the Makefile has the "make bench" target that is run once all the dependencies are installed and the opam file allows installing necessary dependencies for the benchmarks.