fix: support auto mount certs for minioJob #2288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: support auto mount cert for minioJob
ramondeklein
previously approved these changes
Aug 23, 2024
|
@dvaldivia This PR should also be merged downstream. |
added 4 commits
August 23, 2024 14:35
ramondeklein
requested changes
Aug 23, 2024
ramondeklein
approved these changes
Aug 24, 2024
shtripat
reviewed
Aug 26, 2024
There was a problem hiding this comment.
overall looks good. take care of comments from @ramondeklein
shtripat
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: support auto mount certs for minioJob