-
Notifications
You must be signed in to change notification settings - Fork 491
Description
I need to have bucket metrics in grafana. I know that I can create a ScrapeConfig for it, but it is frustrating because there is some manual actions in order to achieve this, and my environment is completely managed by Argocd.
When you set prometheusOperator: true in a Tenant values, it create a scape config only on /minio/v2/metrics/cluster, which is hardcoded in the constant MinIOPrometheusPathCluster in constants.go.
Minio provides the following v2 metrics paths:
- cluster
- bucket
- node
- resource
It would be nice to have the possibility to enable the metrics or not (the values should mention the PROMETHEUS_NAMESPACE which has to be set at the operator level, btw).
A possible implementation would be to add a configuration option which could look like this:
prometheusOperatorScrape:
cluster: true
bucket: true
node: false
resource: false
Or maybe a list, so if minio adds metrics there is no need to modify the controller:
prometheusOperatorScrapes:
- cluster
- bucket
As a final word, the ScrapeInterval is also hardcoded, it'd also be nice to have it configurable.
If you find this of interest, I am happy to help with a PR.