added optional "--model_dir" and "--checkpoint_dir" parameters #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al code refactoring.
Owner
|
What use case are you hitting that requires you to use nonstandard checkpoint/model folders, out of curiosity? |
|
It's me on my personal account: To put it simply, we want to use models stored/synced in different locations and symbolic links can only get you so far before getting too messy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added model_dir and checkpoint_dir parameters. Minimal code refactoring.
Tested finetuning and generating with and without these parameters, everything works as intended.
If these params are not used, the behaviour is the same as before.