Skip to content

Add bike mod #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add bike mod #123

wants to merge 4 commits into from

Conversation

@Lazerbeak12345
Copy link
Collaborator

@Lazerbeak12345 Lazerbeak12345 commented Aug 17, 2022 •
edited
Loading

@Lazerbeak12345 Lazerbeak12345 linked an issue Aug 17, 2022 that may be closed by this pull request
Bike mod #40
Open
3 tasks
@Lazerbeak12345
Copy link
Collaborator Author

Lazerbeak12345 commented Aug 17, 2022

I can't update the mod_sources.txt as doing so changes the git commit of nearly all homedecor mods. this is even if I do a git submodule deinit --all --force followed by a git submodule init --recursive (drastic measures)

@Lazerbeak12345
Copy link
Collaborator Author

Lazerbeak12345 commented Aug 18, 2022

This PR can be turned into a real pr when #124 closes

@Lazerbeak12345 Lazerbeak12345 mentioned this pull request Aug 18, 2022
Merged
@Lazerbeak12345
Copy link
Collaborator Author

Lazerbeak12345 commented Aug 20, 2022

This force push is a rebase due to the merge of #121

@Lazerbeak12345 Lazerbeak12345 mentioned this pull request Aug 20, 2022
Closed
Lazerbeak12345
Lazerbeak12345 commented Aug 20, 2022
View reviewed changes
@Lazerbeak12345 Lazerbeak12345 requested a review from dacmot August 20, 2022 04:16
@Lazerbeak12345
Copy link
Collaborator Author

Lazerbeak12345 commented Aug 20, 2022

I know it's a bit premature to request review when it's in draft, but perhaps you have a better idea of what's happening?

@Lazerbeak12345 Lazerbeak12345 marked this pull request as ready for review August 20, 2022 16:49
@Lazerbeak12345 Lazerbeak12345 requested a review from bell07 August 20, 2022 16:50
@Lazerbeak12345 Lazerbeak12345 self-assigned this Sep 2, 2022
@Lazerbeak12345 Lazerbeak12345 marked this pull request as draft September 9, 2022 02:16
@Lazerbeak12345
Copy link
Collaborator Author

Lazerbeak12345 commented Sep 9, 2022

Re-marked as draft till several of the concerns we have in #40 are resolved

@Lazerbeak12345
Copy link
Collaborator Author

Lazerbeak12345 commented Sep 27, 2023

updated OP to reflect current status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dacmot dacmot Awaiting requested review from dacmot

@bell07 bell07 Awaiting requested review from bell07

Assignees

@Lazerbeak12345 Lazerbeak12345

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bike mod

3 participants

@Lazerbeak12345 @dacmot