fix: Fix sparse slice bug in hello_model.py(#2414) #2417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinjuan zhou <[email protected]>
|
/assign @czs007 |
|
/assign |
|
/lgtm |
|
@wxywb: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wxywb, XuanYang-cn, zjjzyl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
XuanYang-cn
added
the
PR | need to cherry-pick to 2.x
XuanYang-cn
added
PR | cherry-picked to 2.x
XuanYang-cn
pushed a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Feb 21, 2025
- fix: type annotation in Hits and docs in Collection (milvus-io#2387) - enhance: update float16/bfloat16 examples (milvus-io#2388) - fix: sparse slice bug in hello_model.py(milvus-io#2414) (milvus-io#2417) - fix: pkg_resources api deprecated warning (milvus-io#2438) - enhance: Use new model pkg (milvus-io#2595) See also: milvus-io/milvus#37448 Co-authored-by: Yinzuo Jiang <[email protected]> Co-authored-by: Yinzuo Jiang <[email protected]> Co-authored-by: jinjuan zhou <[email protected]> Co-authored-by: jinjuan zhou <[email protected]> Co-authored-by: zhuwenxing <[email protected]> Co-authored-by: junjie.jiang <[email protected]> Signed-off-by: yangxuan <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Mar 4, 2025
- fix: type annotation in Hits and docs in Collection (#2387) - enhance: update float16/bfloat16 examples (#2388) - fix: sparse slice bug in hello_model.py(#2414) (#2417) - fix: pkg_resources api deprecated warning (#2438) - enhance: Use new model pkg (#2595) See also: milvus-io/milvus#37448 Signed-off-by: yangxuan <[email protected]> Co-authored-by: Yinzuo Jiang <[email protected]> Co-authored-by: Yinzuo Jiang <[email protected]> Co-authored-by: jinjuan zhou <[email protected]> Co-authored-by: zhuwenxing <[email protected]> Co-authored-by: junjie.jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes a bug in
examples/milvus_model/hello_model.pywhere indexing a sparse matrix withx[0]caused aNotImplementedError.Changes made:
x[0]tox[:, [0]]to use explicit 2D indexing, which is supported.