Skip to content

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 4, 2024

enhance :
alterindex delete properties
We have introduced a new parameter deleteKeys to the alterindex functionality, which allows for the deletion of properties within an index. This enhancement provides users with the flexibility to manage index properties more effectively by removing specific keys as needed.
altercollection delete properties
We have introduced a new parameter deleteKeys to the altercollection functionality, which allows for the deletion of properties within an collection. This enhancement provides users with the flexibility to manage collection properties more effectively by removing specific keys as needed.
3.support altercollectionfield
We currently support modifying the fieldparams of a field in a collection using altercollectionfield, which only allows changes to the max-length attribute.
Key Points:
New Parameter - deleteKeys: This new parameter enables the deletion of specified properties from an index. By passing a list of keys to deleteKeys, users can remove the corresponding properties from the index.
Mutual Exclusivity: The deleteKeys parameter cannot be used in conjunction with the extraParams parameter. Users must choose one parameter to pass based on their requirement. If deleteKeys is provided, it indicates an intent to delete properties; if extraParams is provided, it signifies the addition or update of properties.
issue :#2338

@JsDove
Copy link
Contributor Author

JsDove commented Dec 4, 2024

@czs007 help review

@czs007
Copy link
Contributor

czs007 commented Dec 10, 2024

/approve
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JsDove JsDove force-pushed the enhance_alterindex branch from 1b7ab66 to 0cb539d Compare December 10, 2024 12:15
@czs007
Copy link
Contributor

czs007 commented Dec 10, 2024

/lgtm

Signed-off-by: Xianhui.Lin <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 10, 2024
@mergify mergify bot added the ci-passed label Dec 10, 2024
@czs007
Copy link
Contributor

czs007 commented Dec 10, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 1f5255a into milvus-io:master Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants