Skip to content

Conversation

xiaocai2333
Copy link
Contributor

No description provided.

@XuanYang-cn
Copy link
Contributor

@xiaocai2333 What's this PR for?

@xiaocai2333
Copy link
Contributor Author

@xiaocai2333 What's this PR for?

In milvus_client, it's referred to as filter rather than expr, so it should also be called filter_params here?
@XuanYang-cn please help to review on this.

@XuanYang-cn
Copy link
Contributor

/cc @czs007
Please help review

@XuanYang-cn XuanYang-cn added the PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x label Nov 7, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 8, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e4505ef into milvus-io:master Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants