Skip to content

fix: remove duplicate field name check in pymilvus #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2024
Merged

fix: remove duplicate field name check in pymilvus #2294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pymilvus/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ class ExceptionsMessage:
FunctionIncorrectType = "The function of schema type must be Function."
FieldType = "The field of schema type must be FieldSchema."
FieldDtype = "Field dtype must be of DataType"
FieldNamesDuplicate = "Duplicate field names are not allowed."
ExprType = "The type of expr must be string ,but %r is given."
EnvConfigErr = "Environment variable %s has a wrong format, please check it: %s"
AmbiguousIndexName = "There are multiple indexes, please specify the index_name."
Expand Down
3 changes: 0 additions & 3 deletions pymilvus/orm/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,6 @@ def _check_fields(self):
primary_field_name = self._kwargs.get("primary_field", None)
partition_key_field_name = self._kwargs.get("partition_key_field", None)
clustering_key_field_name = self._kwargs.get("clustering_key_field", None)
field_names = [field.name for field in self._fields]
if len(field_names) != len(set(field_names)):
raise ParamError(message=ExceptionsMessage.FieldNamesDuplicate)
for field in self._fields:
if primary_field_name and primary_field_name == field.name:
field.is_primary = True
Expand Down