Skip to content

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Mar 25, 2024

issue: milvus-io/milvus#32282

  • Add param config for create_resource_group api.

  • Add update_resource_groups api to implement declarative resource group api.

  • Add new example for declarative resource group api.

@mergify mergify bot added the dco-passed label Mar 25, 2024
@chyezh chyezh force-pushed the feat_resource_group_enhancement branch from f187856 to 6f5e2c0 Compare March 28, 2024 11:17
@chyezh chyezh force-pushed the feat_resource_group_enhancement branch from 6f5e2c0 to 54c40b6 Compare April 9, 2024 06:21
@chyezh chyezh force-pushed the feat_resource_group_enhancement branch from 5a760ca to e87e579 Compare April 9, 2024 07:14
@chyezh chyezh force-pushed the feat_resource_group_enhancement branch from e87e579 to ca15e9d Compare April 12, 2024 09:54
@chyezh chyezh force-pushed the feat_resource_group_enhancement branch from ca15e9d to 31f54e4 Compare April 12, 2024 09:58
@mergify mergify bot added the ci-passed label Apr 12, 2024
Copy link
Contributor

@longjiquan longjiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chyezh
Copy link
Contributor Author

chyezh commented Apr 15, 2024

fixed example issue:

fix: fix example error

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit a270a35 into milvus-io:master Apr 15, 2024
@chyezh chyezh deleted the feat_resource_group_enhancement branch April 15, 2024 11:37
chyezh added a commit to chyezh/pymilvus that referenced this pull request Apr 26, 2024
issue: milvus-io/milvus#30931

- Add param `config` for `create_resource_group` api.

- Add `update_resource_groups` api to implement declarative resource
group api.

- Add new example for declarative resource group api.

---------

Signed-off-by: chyezh <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Apr 26, 2024
)

issue: milvus-io/milvus#32282
picked from pr: #2002

- Add param `config` for `create_resource_group` api.

- Add `update_resource_groups` api to implement declarative resource
group api.

- Add new example for declarative resource group api.

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants