fix(core): fix same-second dates diffing #6094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-abrioux
changed the title
alexandre-abrioux
changed the title
B4nan
approved these changes
Oct 1, 2024
|
I reverted the test changes made in 55df57f, the CI should pass now |
B4nan
reviewed
Oct 1, 2024
Comment on lines
+64
to
+65
| healthcheck: | ||
| test: /opt/mssql-tools/bin/sqlcmd -S mssql -U sa -P 'Root.Root' -Q 'select 1' |
There was a problem hiding this comment.
@boenrobot looks like this solves the flaky CI runs
There was a problem hiding this comment.
Hmm or maybe not :D but it feels better, lets see
There was a problem hiding this comment.
Hm, spoke too soon, judging by the latest commit results in master. But I'm sure this does help reduce the flaky-ness.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6094 +/- ##
=======================================
Coverage 99.79% 99.79%
=======================================
Files 264 264
Lines 18756 18757 +1
Branches 4090 4090
=======================================
+ Hits 18717 18718 +1
Misses 39 39 ☔ View full report in Codecov by Sentry. |
B4nan
pushed a commit
that referenced
this pull request
Oct 7, 2024
This PR fixes an issue I introduced in #6094 Using `toISOString()` on an invalid date throws a [RangeError exception](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date/toISOString#exceptions). We should test if the date is valid before comparing it with `toISOString()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small PR fixes a minor regression that I think was introduced in 55df57f.
Issue
When updating an entity and changing a date property to another one very close to it (by a difference in microseconds), the change is not persisted in the database. Indeed, diffing dates by comparing the
toString()output doesn't give enough precision to compare microseconds shifts. Example:toString()output:Tue Oct 01 2024 08:54:48 GMT+0000 (Coordinated Universal Time)toISOString()output:2024-10-01T08:54:48.651ZTwo dates can have the same
toString()output even though theirtoISOString()output is different.The impact is low and probably only concerns the test scenarios: It's rare to persist the same entity twice in the same second without changing anything other than a date.
Fix
In this PR I'm switching the dates comparison to use
toISOString()and adding a new unit test.