fix(mongo): fix persisting objects like ObjectID
in JSON properties
#6091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in v6.3.11.
After upgrading from v6.3.10 to v6.3.11, ObjectID subproperties of JSON properties are not persisted in the MongoDB database.
The fix reverts the change in 55df57f that uses
structuredClone
instead ofUtils.clone()
to convert JSON to database values in the MongoDB driver. Unfortunately,structuredClone
doesn't clone non-built-in classes (see supported types).I've added a condition to
Utils.clone
to continue supporting both tests:Related issues: