bug: non-english LOCAL causes errors is non-git directories

[vojor]

• git-prompt.lua

return {
    {
        "mikesmithgh/git-prompt-string-lualine.nvim",
        lazy = true,
    },
    {
        "nvim-lualine/lualine.nvim",
        optional = true,
        opts = function(_, opts)
            return vim.tbl_deep_extend("force", opts, {
                sections = {
                    lualine_b = { "git_prompt_string" },
                },
            })
        end,
    },
}

• lualine.lua

    {
        "nvim-lualine/lualine.nvim",
        event = "VeryLazy",
        init = function()
            vim.g.lualine_laststatus = vim.o.laststatus
            if vim.fn.argc(-1) > 0 then
                vim.o.statusline = " "
            else
                vim.o.laststatus = 0
            end
        end,
        opts = function()
            local lualine_require = require("lualine_require")
            lualine_require.require = require

            local icons = require("core.icons").icons

            vim.o.laststatus = vim.g.lualine_laststatus

            return {
                options = {
                    theme = "auto",
                    globalstatus = true,
                    disabled_filetypes = { statusline = { "dashboard", "alpha", "starter" } },
                },
                sections = {
                    lualine_a = { "mode" },
                    lualine_b = { "branch" },

                    lualine_c = {
                        GionVim.lualine.root_dir(),
                        {
                            "diagnostics",
                            symbols = {
                                error = icons.diagnostics.Error,
                                warn = icons.diagnostics.Warn,
                                info = icons.diagnostics.Info,
                                hint = icons.diagnostics.Hint,
                            },
                        },
                        { "filetype", icon_only = true, separator = "", padding = { left = 1, right = 0 } },
                        { GionVim.lualine.pretty_path() },
                    },
                    lualine_x = {
                        {
                            function()
                                return require("noice").api.status.command.get()
                            end,
                            cond = function()
                                return package.loaded["noice"] and require("noice").api.status.command.has()
                            end,
                            color = GionVim.ui.fg("Statement"),
                        },
                        {
                            function()
                                return require("noice").api.status.mode.get()
                            end,
                            cond = function()
                                return package.loaded["noice"] and require("noice").api.status.mode.has()
                            end,
                            color = GionVim.ui.fg("Constant"),
                        },
                        {
                            require("lazy.status").updates,
                            cond = require("lazy.status").has_updates,
                            color = GionVim.ui.fg("Special"),
                        },
                        {
                            "diff",
                            symbols = {
                                added = icons.git.added,
                                modified = icons.git.modified,
                                removed = icons.git.removed,
                            },
                            source = function()
                                local gitsigns = vim.b.gitsigns_status_dict
                                if gitsigns then
                                    return {
                                        added = gitsigns.added,
                                        modified = gitsigns.changed,
                                        removed = gitsigns.removed,
                                    }
                                end
                            end,
                        },
                    },
                    lualine_y = {
                        { "encoding", separator = "|" },
                        { "progress", separator = " ", padding = { left = 1, right = 0 } },
                        { "location", padding = { left = 0, right = 1 } },
                    },
                    lualine_z = {
                        function()
                            return " " .. os.date("%R")
                        end,
                    },
                },
                extensions = { "neo-tree", "lazy" },
            }
        end,
    },

• An error message appears when opening files in a folder without a '.git' directory
• message: git-prompt-string-lualine.nvim: ERROR git-prompt-string error(read file HEAD): "open HEAD: no such file or directory".

[mikesmithgh]

@legbor thanks for reporting. I'm not able to reproduce the issue. Please answer a couple of questions to help me troubleshoot.

1. What OS are you using?
2. Does this happen for every directory that does not contain a .git directory or a specific one?
3. Could you provide your git version git --version?

[vojor]

• OS: WSL ArchLinux
• Git version: 2.44.0
• Yes, as long as there is no '.git' folder in the current directory, this error prompt will appear.

[vojor]

_Documents.2024-04-22.20-32-59.mp4

[mikesmithgh]

@legbor I have a hunch. I may be looking for an error which doesn't get picked up in different languages.

Could you run the following in a nongit directory and provide the output?

git rev-parse --verify --absolute-git-dir --is-inside-git-dir --is-inside-work-tree --is-bare-repository --is-shallow-repository --abbrev-ref @{upstream}
echo $?

This is what I see:

git rev-parse --verify --absolute-git-dir --is-inside-git-dir --is-inside-work-tree --is-bare-repository --is-shallow-repository --abbrev-ref @{upstream}
echo $?
fatal: not a git repository (or any of the parent directories): .git
128

[mikesmithgh]

ah reproduced it 👍

export LC_ALL='zh_CN.UTF-8'

I see the problem, will work on fixing it. Thanks for reporting!

[mikesmithgh]

@legbor I added a fix in git-prompt-string v1.3.2. Could you update git-prompt-string and try again?

[vojor]

@mikesmithgh Thank you for your work. I have updated the program and the issue has been resolved.

[mikesmithgh]

@legbor awesome!