Fix cuda mp #2023
Merged
Fix cuda mp #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2025 13:05
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issues related to CUDA multiprocessing and updates default CLI parameters.
- Forces the multiprocessing start method to "spawn" to help with CUDA compatibility.
- Updates the default frames-per-second (FPS) value in the command-line interface from None to 30.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| boxmot/engine/val.py | Adds multiprocessing spawn start and removes an unused import |
| boxmot/engine/cli.py | Changes the default FPS value to 30 |
Comments suppressed due to low confidence (1)
boxmot/engine/cli.py:40
- Changing the default FPS value from None to 30 alters the API behavior; please update the accompanying documentation or comments to clarify this breaking change.
common_parser.add_argument('--fps', type=int, default=30,
Comment on lines
+4
to
+5
| mp.set_start_method("spawn", force=True) | ||
|
|
There was a problem hiding this comment.
Consider moving the mp.set_start_method call into a main guard or ensure it is invoked only once to avoid conflicts when the module is imported in different contexts.
Suggested change
| mp.set_start_method("spawn", force=True) | |
| if __name__ == "__main__": | |
| mp.set_start_method("spawn", force=True) |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.