Skip to content

Conversation

@aganders3
Copy link
Contributor

This fixes some formatting issues in the comparison lists under nricp_amberg and nricp_sumner methods in the documentation.

To get docs building locally I also had to make some changes to the Makefile and Dockerfile. I'm happy to remove these changes if they're for some reason specific to my environment, or if they'd fit better in a separate PR.

Before (current):

Screenshot 2025-09-22 at 11 43 56 AM

After (this PR):

Screenshot 2025-09-22 at 11 43 43 AM

@mikedh
Copy link
Owner

mikedh commented Sep 22, 2025

Looks much nicer, thanks for the fix! The docker changes look reasonable to me, but just out of curiosity what platform are they for? M1 macs?

@mikedh mikedh changed the base branch from main to feat/view September 22, 2025 19:29
@mikedh mikedh merged commit 51291d9 into mikedh:feat/view Sep 22, 2025
11 checks passed
@aganders3
Copy link
Contributor Author

Thanks!

The docker changes look reasonable to me, but just out of curiosity what platform are they for? M1 macs?

Yes, on my M1 Mac it failed trying to build vahcdx with this error:

 > [build 3/3] RUN pip install /home/user[easy]:
2.610         File
2.610       "/home/user/.cache/uv/builds-v0/.tmplbNhBF/lib/python3.13/site-packages/pybind11/setup_helpers.py",
2.610       line 268, in auto_cpp_level
2.610           raise RuntimeError(msg)
2.610       RuntimeError: Unsupported compiler -- at least C++11 support is needed!
2.610 
2.610       hint: This usually indicates a problem with the package or the build
2.610       environment.
2.610   help: `vhacdx` (v0.0.8.post2) was included because `trimesh[easy]` (v4.8.2)
2.610         depends on `vhacdx`

I believe by default a Docker on an Apple Silicon Mac will build an ARM64 image, so it would need a manylinux aarch64 wheel to work inside the container without having to build it.

@aganders3
Copy link
Contributor Author

aganders3 commented Sep 22, 2025

Ah, haha I'm now seeing that package is under the trimesh org. So perhaps it could be worth trying to add such a wheel? It may not be a huge task since it's already using cibuildwheel, which should support building Linux ARM wheels on GitHub Actions with the ubuntu-24.04-arm runner: https://cibuildwheel.pypa.io/en/stable/ci-services/#github-actions

mikedh added a commit that referenced this pull request Sep 26, 2025
- For the notebook viewer this updates the version of three.js from 115
-> 140 and rebuilds the `trimesh.resources.viewer.zip` artifact. The
latest version of three.js is 180 but would require re-factoring the
notebook viewer which probably should be done at some point.
- releases #2464
- add literals types instead of loose strings for `BooleanEngineType`,
`BooleanOperationType`, and `GraphEngineType`, and apply them to boolean
and graph functions that allow different `engine` options.
- pass through `repair` keyword argument from `Trimesh.split` to
partially fix #2460
- deprecate `trimesh.viewer.widget` since `glooey` hasn't been updated
since 2021, and the widget module isn't tested.
- stop running `process=True` on the outputs of manifold3d to fix #2466 
- adds additional test case to hit the iteration path of
`trimesh.path.polygons.sample_polygon`
- stop double-checking `is_volume` in mesh booleans to fix #2458
- Adds additional documentation recommending "a la carte" dependencies
for people freezing, i.e. `trimesh scipy` vs `trimesh[easy]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants