Updated integral_mean_curvature function #2416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Awesome thanks for the PR and test! Quick question, do we need another function and attribute for |
Contributor
Author
|
Thank you for the review. You are right! I initially added |
Owner
|
Looks great thanks for the update! |
mikedh
added a commit
that referenced
this pull request
Jun 11, 2025
mikedh
added a commit
that referenced
this pull request
Jun 27, 2025
- add and test `path.copy(layers={1, 2})` to only copy particular
layers.
- add the note about signed angles discussed in #2416
- add a `trimesh.primitives.Extrusion(..., mid_plane: bool)` option as a
helper to produce extrusions that are centered at the origin.
- convert `test_extrude` and `test_primitives` to pytest style, and
remove the outdated test skip if `triangle` isn't installed.
- fix and test units on 3MF imports, which were being stomped by the
`metadata = None` keyword argument.
- remove unused `trimesh.exchange.gltf._mesh_to_materials` function.
- release #2420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integral_mean_curvature (IMC) function did not agree with the analytical value for non-convex objects such as a torus and an annulus. The angle in the function needs to have an appropriate sign to detect concave angles. This code corrects that error and also adds a test function for IMC to test for non-convex objects.