Fix (PreferenceRestorer): correctly backup/restore preferences related to categories #1726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe we should also keep the category id when making backup and set this preferences accordingly? |
That would be better comparing to using |
|
cuong-tran
force-pushed
the
backup-restore-category-pref
branch
from
8684da2 to
14a1ef2
Compare
AntsyLich
requested changes
Feb 22, 2025
app/src/main/java/eu/kanade/tachiyomi/data/backup/models/BackupCategory.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/eu/kanade/tachiyomi/data/backup/restore/restorers/PreferenceRestorer.kt
Outdated
Show resolved
Hide resolved
…d to category (cherry picked from commit ff8d48bf4ce80a13e314818fc133360e3df18863)
revert PreferenceBackupCreator
cuong-tran
force-pushed
the
backup-restore-category-pref
branch
from
14a1ef2 to
ce760fc
Compare
AntsyLich
approved these changes
Feb 24, 2025
cuong-tran
added a commit
to komikku-app/komikku
that referenced
this pull request
Feb 25, 2025
Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit e1724d1aa0e3340e1404cfd80bd264831d86a879)
cuong-tran
added a commit
to komikku-app/komikku
that referenced
this pull request
Feb 26, 2025
… preferences (mihonapp/mihon#1726) Co-authored-by: AntsyLich <[email protected]> (cherry picked from commit e1724d1aa0e3340e1404cfd80bd264831d86a879)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preferences related to category:
They are being stored in preferences as category ID and hence failed to be backed up/restored correctly.