Skip to content

Conversation

Animeboynz
Copy link
Contributor

@Animeboynz Animeboynz commented Sep 18, 2024

Resolves #1187
Adds options to both Onboarding and the Security and Privacy Screen to toggle Analytics and Crashlytics

Before After
image image
image image0

@Animeboynz Animeboynz marked this pull request as ready for review September 21, 2024 14:05
Copy link
Member

@AntsyLich AntsyLich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename SettingsSecurityScreen to SettingsSecurityPrivacyScreen?

@Animeboynz
Copy link
Contributor Author

Rename SettingsSecurityScreen to SettingsSecurityPrivacyScreen?

I can if you really want to.
The in app setting was always called Security and privacy while the file is SettingsSecurityScreen.kt
also Data and storage is SettingsDataScreen.kt

Co-authored-by: AntsyLich <[email protected]>
@Animeboynz Animeboynz requested a review from AntsyLich October 1, 2024 10:42
@AntsyLich AntsyLich merged commit 7c7af72 into mihonapp:main Oct 12, 2024
1 check passed
@Animeboynz Animeboynz deleted the crashlytics branch October 12, 2024 10:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to opt-out of analytics and crashlytics
3 participants