Skip to content

Added ResponseHeaders and StatusCode to ServiceException constructor. #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2019
Merged

Added ResponseHeaders and StatusCode to ServiceException constructor. #405

merged 3 commits into from
Mar 22, 2019

Conversation

@ksikorsk
Copy link
Contributor

Fixes #
#401

Changes proposed in this pull request

  • Added ServiceException overload to set RequestHeaders and StatusCode.
  • Removed internal setters.
  • Changed HttpProvider to use overload constructor.

@ksikorsk ksikorsk closed this Mar 16, 2019
@ksikorsk ksikorsk reopened this Mar 16, 2019
@MIchaelMainer
Copy link
Contributor

Let's get this in with 1.15.0.

@MIchaelMainer MIchaelMainer changed the base branch from master to dev March 22, 2019 06:21
@MIchaelMainer MIchaelMainer merged commit 112509c into microsoftgraph:dev Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa peombwa peombwa approved these changes

+1 more reviewer

@darrelmiller darrelmiller darrelmiller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ksikorsk @MIchaelMainer @darrelmiller @peombwa