Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 29, 2025

This PR addresses string inconsistencies in the permissions-descriptions.json file between admin and non-admin display names, as reported in the issue.

Issues Fixed

The analysis identified 79 string inconsistencies across 582 permissions, including:

  1. Trailing spaces in display names (e.g., "Read all webhook subscriptions ""Read all webhook subscriptions")
  2. Inconsistent punctuation where some display names ended with periods while others didn't (e.g., "Read and write all users' passkey methods.""Read and write all users' passkey methods")

Changes Made

  • Removed trailing spaces from both adminConsentDisplayName and consentDisplayName fields
  • Standardized punctuation by removing trailing periods from display names for consistency
  • Added comprehensive test coverage with 2,910 test cases to prevent future regressions

Examples of Fixes

- "adminConsentDisplayName": "Read all AI Insights for online meetings. "
+ "adminConsentDisplayName": "Read all AI Insights for online meetings"

- "consentDisplayName": "Read your approval items, approval requests and approval responses "
+ "consentDisplayName": "Read your approval items, approval requests and approval responses"

- "adminConsentDisplayName": "Read and write all users' passkey methods."
+ "adminConsentDisplayName": "Read and write all users' passkey methods"

Validation

  • JSON syntax validation confirms the file remains valid
  • Created a new test suite (tests/permissions-descriptions.spec.js) that validates all permissions for proper formatting
  • Re-ran analysis script to confirm zero remaining inconsistencies

These changes improve the consistency and professional appearance of permission display names without altering their meaning or functionality.

Fixes #223.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • docs.microsoft.com
    • Triggering command: node scripts/test-initiator.js (dns block)
  • learn.microsoft.com
    • Triggering command: node scripts/test-initiator.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@Copilot Copilot AI changed the title [WIP] String inconsistencies in permissions-descriptions.json Fix string inconsistencies in permissions-descriptions.json Aug 29, 2025
@Copilot Copilot AI requested a review from jasonjoh August 29, 2025 16:39
Copilot finished work on behalf of jasonjoh August 29, 2025 16:39
@jasonjoh jasonjoh marked this pull request as ready for review August 29, 2025 17:01
@Copilot Copilot AI review requested due to automatic review settings August 29, 2025 17:01
@jasonjoh jasonjoh requested a review from a team as a code owner August 29, 2025 17:01
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes string inconsistencies in the permissions-descriptions.json file by removing trailing spaces and standardizing punctuation across permission display names.

  • Removes trailing spaces from both adminConsentDisplayName and consentDisplayName fields
  • Standardizes punctuation by removing trailing periods from display names
  • Adds comprehensive test coverage to prevent future formatting regressions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
permissions/permissions-descriptions.json Cleaned up 79 string inconsistencies by removing trailing spaces and periods from permission display names
tests/permissions-descriptions.spec.js Added new test suite with comprehensive validation for trailing/leading spaces and period consistency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

String inconsistencies in permissions-descriptions.json

2 participants