Skip to content

Conversation

@mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Jul 9, 2025

PR sets the User-Agent request header in the standard format (WinGetCreate/<Cli-Version>)

For reference, the winget-cli user-agent is winget-cli WindowsPackageManager/<CLI-Version> DesktopAppInstaller/<AppInstaller-Version>. The comment in the source code mentions that winget-cli is there for historical reasons.

https://github.com/microsoft/winget-cli/blob/8115f41de486ef4c4a4cc064be57016ee5cbe44e/src/AppInstallerCommonCore/Runtime.cpp#L533-L543

Validation

Manually verified that wingetcreate new https://www.atlassian.com/software/jira/downloads/binary/atlassian-jira-software-9.12.25-x64.exe works after settings the User-Agent


Microsoft Reviewers: Open in CodeFlow

@denelon denelon added this to the 1.11 Create milestone Jul 9, 2025
@AmelBawa-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mdanish-kh
Copy link
Contributor Author

Pipeline failing for the same reason: #597 (comment)

@AmelBawa-msft AmelBawa-msft merged commit 9663e89 into microsoft:main Jul 10, 2025
3 of 5 checks passed
@mdanish-kh mdanish-kh deleted the user-agent branch July 10, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WingetCreate does not use a user-agent header string to download content.

3 participants