Add new Retained attribute to OVERLAPPED parameters #1792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
previously approved these changes
Jan 5, 2024
Member
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
This looks good. But what about DeviceIoControl? Are there other APIs that use OVERLAPPED pointers that we should include in this?
Collaborator
Collaborator
Author
|
Thanks for the ping. I can add those to this PR too. Standby. |
Member
|
@riverar any update? |
Collaborator
Author
|
Catching up on PRs, good timing. Adding now. |
Collaborator
Author
|
Updated. If I missed any APIs, happy to add them. |
AArnott
previously approved these changes
May 3, 2024
mikebattista
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1726
Add a new
Retainedattribute to indicate when pointers to structures must remain allocated throughout the lifetime of an asynchronous operation.