Make async VSTestConsoleWrapper apis obsolete #4648
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
approved these changes
Aug 8, 2023
This was referenced Jul 22, 2025
Merged
This was referenced Oct 22, 2025
Open
Open
Merged
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
LegacyDre/skills-secure-repository-supply-chain#6
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4592
VSTest console wrapper apis are not following the rules of good async APIs, they don't internally use the async apis for communication, and start session just plain does not work because it awaits before it attempts to connect.
We don't have a plan to fix them, and would have to change the public apis when we do this redesign, marking them as obsolete, with one exception of the postProcessingAsync API which does not have a sync equivalent.