[rel/17.14] Fix setting DOTNET_ROOT #15252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
approved these changes
Aug 11, 2025
|
Do you have a backport PR already for net9 (on SDK side)? Also we need to track insertion to net9 right? |
|
no, it will need to be tacked onto the insertion of this change. |
|
@nohwnd Hmm, don't we need dotnet/sdk#49634 to be brought for net9? |
|
Yes, that is what I am saying. I don't have it ready, because it will need to be combined with the insertion of this change into SDK to be able to pass tests. |
|
Ah. I misread your comment. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fixes for handling dotnet_root when testhost is targetting tfm that is newer than net6.
#15184
#15250
will fix dotnet/sdk#49436 once merged, and the other part of the fix is applied to net9.