Skip to content

Remove unnecessary CA2022 suppressions #15035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2025
Merged

Conversation

Winniexu01
Copy link
Contributor

@Winniexu01 Winniexu01 commented Mar 26, 2025

Related to dotnet/source-build#4322

Remove all the unnecessary CA2022 suppressions

VMR: https://dev.azure.com/dnceng/internal/_build/results?buildId=2673846&view=results (internal Microsoft link)

@Winniexu01 Winniexu01 marked this pull request as draft March 26, 2025 08:59
@Winniexu01 Winniexu01 closed this Mar 26, 2025
@Winniexu01 Winniexu01 reopened this Mar 28, 2025
@nohwnd
Copy link
Member

nohwnd commented Mar 28, 2025

Mention me when you are done :)

@Winniexu01
Copy link
Contributor Author

Winniexu01 commented Mar 28, 2025

Add @MichaelSimons, @NikolaMilosavljevic , @mthalman, @ViktorHofer as reviewers.

@Winniexu01 Winniexu01 marked this pull request as ready for review March 28, 2025 09:58
@Winniexu01
Copy link
Contributor Author

Hi @nohwnd , I have mad a minor update to the code and all the checks are done. Would you mind doing another quick review?

@nohwnd nohwnd merged commit c9a26cb into microsoft:main Mar 31, 2025
7 checks passed
@nohwnd
Copy link
Member

nohwnd commented Mar 31, 2025

Merged thanks.

This was referenced Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants