Don't cancel an all-provider request when the single-provider request is a subset #262987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
reviewed
Aug 22, 2025
| @@ -53,7 +53,7 @@ interface IFetchResult { | |||
| * The sourceLabel must not contain '@'! | |||
| */ | |||
| export function formatRecordableLogEntry<T extends IRecordableLogEntry>(entry: T): string { | |||
| return entry.sourceId + ' @@ ' + JSON.stringify({ ...entry, sourceId: undefined }); | |||
| return entry.sourceId + ' @@ ' + JSON.stringify({ ...entry, modelUri: (entry as any).modelUri?.toString(), sourceId: undefined }); | |||
There was a problem hiding this comment.
Unsafe? Could this get mangled in product build?
There was a problem hiding this comment.
Thanks for paying attention to code smells :)
But I think it is fine here, this is debug logging only. And no, it cannot get mangled, as this is a json object (which would break all kinds of interop, if json object properties would get mangled).
mjbvz
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262986
FYI @benibenj