Make terminal auto approve more aware of paths #259673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring terminal auto approval, users expect path variations to work intuitively. Previously, if you approved
bin/foo
, it would only match that exact path separator style, requiring separate entries for Windows and Unix variants.This change makes the auto approval system path-aware by detecting strings that contain path separators (
/
or\
) and creating flexible regex patterns that handle common path variations:Before:
After:
With this change, approving
bin/foo
automatically allows:bin/foo
(exact match)bin\foo
(Windows backslashes)./bin/foo
(current directory with forward slash).\bin\foo
(current directory with backslash)The implementation:
/
or\
separators[/\\]
for separators./
and.\
patternsecho
,ls
)This makes the terminal auto approval feature more intuitive for cross-platform development workflows where the same logical path might be referenced with different separator styles.
Fixes #259672.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.