Add safe readonly commands to terminal auto approve defaults #259669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive set of safe and common readonly commands to the terminal auto approve defaults, improving the user experience by automatically approving commonly used commands that don't modify system state.
Changes Made
Added Safe Commands (Auto-approved by default)
Unix/Linux commands (16):
echo
,ls
,pwd
,cat
,head
,tail
,grep
,find
,which
,whoami
,date
,hostname
,ps
,wc
,sort
,uniq
PowerShell commands (7):
Get-ChildItem
,Get-Content
,Get-Location
,Get-Date
,Get-Host
,Get-Process
,Get-Service
PowerShell commands use case-insensitive regex patterns (e.g.,
/^Get-ChildItem\\b/i
) to match variations likeget-childitem
orGET-CHILDITEM
.Preserved Security
All existing dangerous commands remain denied by default:
rm
,rmdir
,del
,kill
,curl
,wget
,eval
,chmod
,chown
,Remove-Item
Testing
Added comprehensive test suite covering:
Example Usage
With these defaults, users will no longer need explicit approval for common operations like:
While still requiring approval for potentially dangerous operations:
Users can still override any default by explicitly setting commands to
true
orfalse
in theirchat.tools.terminal.autoApprove
configuration.Fixes #259668.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.