Avoid re-sanitizing markdown during rendering #259655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently rendering markdown sanitizes the content twice. When creating the output element it also goes: `string -> dom-> string -> dom` (with other hops potentially in the implementation) This change changes to a single pass that goes `string -> dom` with a single sanitize call. Since we are moving away from DomParser, the output is slightly changed
|
If the changes appear safe, you can manually trigger the pipeline by commenting |
DonJayamanne
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rendering markdown sanitizes the content twice. When creating the output element it also goes:
string -> dom-> string -> dom(with other hops potentially in the implementation)This change changes to a single pass that goes
string -> domwith a single sanitize call. Since we are moving away from DomParser, the output is slightly changed