Fix checkOutputInputFocus to support Shadow DOM traversal in notebook outputs #259592
+7
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix microsoft/vscode-jupyter#16660
The
checkOutputInputFocus
function in notebook webview preloads was unable to correctly detect focused input elements within Shadow DOMs. When an input element inside a shadow root receives focus,document.activeElement
only returns the shadow host element, not the actual focused element within the shadow DOM.This caused issues with notebook outputs that render content inside shadow roots, where focus detection for input elements would fail, preventing proper input focus state tracking.
Changes
Enhanced the
checkOutputInputFocus
function to traverse shadow DOM boundaries:The implementation:
activeElement
fromconst
tolet
to allow reassignmentThis follows the same pattern used elsewhere in the codebase for shadow DOM traversal and ensures accurate focus detection for inputs encapsulated in shadow roots.
Fixes focus detection for notebook output cells that use shadow DOM for rendering, improving the overall user experience when interacting with complex notebook outputs.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.