Avoid 0ms interval rescheduling in configuration service #259524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259517
This change prevents an infinite loop of immediate scheduler execution when
ASSIGNMENT_REFETCH_INTERVAL
is set to 0 (meaning no polling should occur).Problem
The
ConfigurationDefaultOverridesContribution
class was unconditionally rescheduling its experimental settings scheduler, even whenASSIGNMENT_REFETCH_INTERVAL
was set to 0. This caused:Solution
Added a conditional check before rescheduling the scheduler:
When
ASSIGNMENT_REFETCH_INTERVAL
is 0, the scheduler will run once but won't reschedule itself, properly implementing the "no polling" behavior.Cherry-picked from commit d38eb0f by @hediet.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.