Skip to content

Chat code block pill token updates #250531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jun 5, 2025
Merged

Chat code block pill token updates #250531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
96c5eac
update colors for icon labels to meet accessibility color contrast r…
Jun 3, 2025
7b5da20
- update colors for added and removed labels to pass color contrast r…
Jun 3, 2025
623b014
Merge branch 'microsoft:main' into passive-bird
kkbrooks Jun 3, 2025
513b5cf
fixing margin-left
Jun 3, 2025
f75101c
Merge branch 'main' into passive-bird
kkbrooks Jun 3, 2025
f033355
Merge branch 'main' into passive-bird
kkbrooks Jun 3, 2025
4a8da7e
Merge branch 'main' into passive-bird
kkbrooks Jun 3, 2025
6b847de
update editor gutter colors for added and deleted resources, removed …
Jun 4, 2025
64d4fcf
update editor gutter colors for added and deleted lines in dark_moder…
Jun 4, 2025
7e45726
Merge branch 'microsoft:main' into passive-bird
kkbrooks Jun 4, 2025
4bd3cd7
undoing changes to editorGutterAddedBackground and editorGutterDelete…
Jun 4, 2025
a77d9e8
add foreground colors for added and deleted lines in chat code blocks…
Jun 4, 2025
eee5a50
add chat foreground colors for added and deleted lines in vscode-know…
Jun 4, 2025
3c286e3
rename chat color variables for added and removed lines in chat code …
Jun 4, 2025
5b5f0fb
Merge branch 'main' into passive-bird
kkbrooks Jun 4, 2025
7e6f7dc
Merge branch 'main' into passive-bird
kkbrooks Jun 4, 2025
88485bc
Merge branch 'main' into passive-bird
kkbrooks Jun 4, 2025
fddef92
Merge branch 'main' into passive-bird
kkbrooks Jun 4, 2025
a118fc9
Merge branch 'main' into passive-bird
kkbrooks Jun 5, 2025
3eeaf0d
Merge branch 'main' into passive-bird
kkbrooks Jun 5, 2025
a1735ae
Merge branch 'main' into passive-bird
kkbrooks Jun 5, 2025
d66028e
Merge branch 'main' into passive-bird
justschen Jun 5, 2025
c2b6e4d
Merge branch 'main' into passive-bird
justschen Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion build/lib/stylelint/vscode-known-variables.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@
"--vscode-chat-requestCodeBorder",
"--vscode-chat-slashCommandBackground",
"--vscode-chat-slashCommandForeground",
"--vscode-chat-linesAddedForeground",
"--vscode-chat-linesRemovedForeground",
"--vscode-checkbox-background",
"--vscode-checkbox-border",
"--vscode-checkbox-disabled-background",
Expand Down Expand Up @@ -957,4 +959,4 @@
"--animation-opacity",
"--chat-setup-dialog-glow-angle"
]
}
}
4 changes: 2 additions & 2 deletions src/vs/base/browser/ui/iconLabel/iconlabel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@
}

.monaco-icon-label > .monaco-icon-label-container > .monaco-icon-suffix-container > .label-suffix {
opacity: .7;
color: var(--vscode-peekViewTitleDescription-foreground);
white-space: pre;
}

.monaco-icon-label > .monaco-icon-label-container > .monaco-icon-description-container > .label-description {
opacity: .7;
color: var(--vscode-peekViewTitleDescription-foreground);
margin-left: 0.5em;
font-size: 0.9em;
white-space: pre; /* enable to show labels that include multiple whitespaces */
Expand Down
4 changes: 2 additions & 2 deletions src/vs/workbench/contrib/chat/browser/media/chatCodeBlockPill.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,11 @@ span.label-detail {
span.label-added {
font-weight: bold;
padding-left: 4px;
color: var(--vscode-editorGutter-addedBackground);
color: var(--vscode-chat-linesAddedForeground);
}

span.label-removed {
font-weight: bold;
padding-left: 4px;
color: var(--vscode-editorGutter-deletedBackground);
color: var(--vscode-chat-linesRemovedForeground);
}
10 changes: 10 additions & 0 deletions src/vs/workbench/contrib/chat/common/chatColors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,13 @@ export const chatEditedFileForeground = registerColor(
export const chatRequestCodeBorder = registerColor('chat.requestCodeBorder', { dark: '#004972B8', light: '#0e639c40', hcDark: null, hcLight: null }, localize('chat.requestCodeBorder', 'Border color of code blocks within the chat request bubble.'), true);

export const chatRequestBubbleBackground = registerColor('chat.requestBubbleBackground', { light: transparent(editorSelectionBackground, 0.3), dark: transparent(editorSelectionBackground, 0.3), hcDark: null, hcLight: null }, localize('chat.requestBubbleBackground', "Background color of the chat request bubble."), true);

export const chatLinesAddedForeground = registerColor(
'chat.linesAddedForeground',
{ dark: '#54B054', light: '#107C10', hcDark: '#54B054', hcLight: '#107C10' },
localize('chat.linesAddedForeground', 'Foreground color of lines added in chat code block pill.'), true);

export const chatLinesRemovedForeground = registerColor(
'chat.linesRemovedForeground',
{ dark: '#FC6A6A', light: '#BC2F32', hcDark: '#F48771', hcLight: '#B5200D' },
localize('chat.linesRemovedForeground', 'Foreground color of lines removed in chat code block pill.'), true);
Loading