Enable model picker label to show ellipsis instead of overflowing #232640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- src/vs/workbench/contrib/chat/browser/media/chat.css: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
justschen
reviewed
Oct 30, 2024
justschen
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
looks good, I think small nit is the structure (in this css file, i don't see a lot of nested css), but i don't think it really matters
.interactive-session .chat-input-toolbars > .chat-execute-toolbar,
.interactive-session .chat-input-toolbars > .chat-execute-toolbar .chat-modelPicker-item {
min-width: 0;
}
.interactive-session .chat-input-toolbars > .chat-execute-toolbar .chat-modelPicker-item .chat-model-label {
min-width: 0;
overflow: hidden;
text-overflow: ellipsis;
}
.interactive-session .chat-input-toolbars > .chat-execute-toolbar .chat-modelPicker-item .codicon {
flex-shrink: 0;
}
|
Nested selectors are very new, but they are good and I think we can start to use them in more places. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #231369