Skip to content

ESM merge to main #227184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 42 commits into from
Aug 30, 2024
Merged

ESM merge to main #227184

merged 42 commits into from
Aug 30, 2024

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Aug 30, 2024 •
edited
Loading

Refs: #226260

This PR does the following:

  • rewrite our TS import statements in src folder to be relative and ESM compatible
  • uncomment the comments for ESM support and comment AMD specifics
  • enable a VSCODE_BUILD_AMD to build the AMD variant
  • add ESLint rules to enforce ESM imports

@bpasero bpasero self-assigned this Aug 30, 2024
@bpasero bpasero added this to the September 2024 milestone Aug 30, 2024
@bpasero bpasero marked this pull request as ready for review August 30, 2024 08:17
@bpasero bpasero requested a review from jrieken August 30, 2024 08:18
@bpasero bpasero enabled auto-merge (squash) August 30, 2024 08:21
jrieken
jrieken approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@jrieken jrieken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bpasero bpasero merged commit 6b924c5 into main Aug 30, 2024
12 of 19 checks passed
@bpasero bpasero deleted the esm-merge-to-main branch August 30, 2024 08:31
@bpasero bpasero mentioned this pull request Aug 30, 2024
Closed
13 tasks
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
September 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@bpasero @jrieken